search

carnager / rofi-pass

rofi frontend for pass
GNU General Public License v3.0
699 stars 121 forks source link

Fixup markdown link syntax error #233

Open WalterSmuts opened 1 year ago

Narrat commented 1 year ago

Wouldn't be the actual fix of the markdown syntax to replace the second pair of [] with ()? With the change done by this commit it seems to be broken in different way as the link won't be displayed at all.

WalterSmuts commented 1 year ago

Have a look at the rendered markdown here: https://github.com/WalterSmuts/rofi-pass/tree/markdown-fix

Narrat commented 1 year ago

Yeah, I had a look at that before I wrote the comment. Because I didn't recognize the syntax and wondered how it would look like. And I still don't see it? md-syntax

WalterSmuts commented 1 year ago

https://www.markdownguide.org/basic-syntax/#reference-style-links

Narrat commented 1 year ago

Ah, I see. It shouldn't be displayed down there. Thanks for the patience. One last thought though. All other links are using the general link syntax and now there is one occurrence of a reference style link. Isn't that somewhat confusing in the long run? (As it got me for example, although this stemmed more from the fact that I didn't know about this syntax) Shouldn't be the style in use coherent?

WalterSmuts commented 1 year ago

I think it's okay to use two different language features :shrug: But ultimately is a style/taste decision.