carnal0wnage / weirdAAL

WeirdAAL (AWS Attack Library)
772 stars 92 forks source link

Resolve undefined name 'region'. Use AWS_ACCESS_KEY_ID #49

Closed cclauss closed 6 years ago

cclauss commented 6 years ago

region is an undefined name in this context so this PR recommends using __AWS_ACCESS_KEY_ID__ instead.

flake8 testing of https://github.com/carnal0wnage/weirdAAL on Python 3.6.3

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

./libs/aws_lambda.py:135:86: F821 undefined name 'region'
            print("[-] GetAccountSettings allowed for {} but no results [-]" .format(region))
                                                                                     ^
./libs/s3.py:289:54: F821 undefined name 'file'
            print("{} object does not exist.".format(file))
                                                     ^
2     F821 undefined name 'region'
2
cktricky commented 6 years ago

This LGTM, if not @carnal0wnage we can always revert 👍