Closed artis3n closed 5 years ago
Hey @artis3n 👋 - I had not seen this PR until I got the notification about you closing it. Did you want to keep it closed or reopen?
Ah, no problem. Well, I'm conflicted. I think pipenv
to automatically scope weirdaal's dependencies to a project-specific virtualenv would be beneficial, but people have issues with pipenv that are well summed up in: https://chriswarrick.com/blog/2018/07/17/pipenv-promises-a-lot-delivers-very-little/.
I feel that it's beneficial for weirdAAL's use case, but it's not so much a "definitely use this" as I originally thought when I opened the issue.
You may also want to lock the versions in the Pipfile, I've left them *
(and rely on the Pipfile.lock to store the specific version needed).
Versions locked by Pipfile.lock, simplifies the setup in the Wiki. Upgrade packages in future by running
pipenv update
. I don't have permission to update, but the Setup page of the wiki should now show:setup infoz:
OSX Setup:
Then, all references to
python3
can just bepython
as python 3 will be the only available interpreter inside the pipenv shell.Dependency graph: