carnal0wnage / weirdAAL

WeirdAAL (AWS Attack Library)
772 stars 92 forks source link

modules/aws/recon.py - brute_cloudhsm_permissions() ignores region #80

Open laughingman42 opened 1 year ago

laughingman42 commented 1 year ago

Issue: modules/aws/recon.py - brute_cloudhsm_permissions() ignores region env variable and defaults to us-east-1 causing timeout.

Error output:

### Enumerating CloudHSM Permissions ###
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/urllib3/connection.py", line 169, in _new_conn
    conn = connection.create_connection(
  File "/usr/lib/python3/dist-packages/urllib3/util/connection.py", line 96, in create_connection
    raise err
  File "/usr/lib/python3/dist-packages/urllib3/util/connection.py", line 86, in create_connection
    sock.connect(sa)
socket.timeout: timed out
...
...
urllib3.exceptions.ConnectTimeoutError: (<botocore.awsrequest.AWSHTTPSConnection object at 0x7f936a01be20>, 'Connection to cloudhsm.us-east-1.amazonaws.com timed out. (connect timeout=60)')

Fix: Commenting out call to brute_cloudhsm_permissions() in recon.py allows recon to complete successfully. Seems it should be using brute_cloudhsmv2_permissions() in any case?