carneades / carneades-4

Version 4 of Carneades, implemented in Go
https://carneades.github.io/
Other
48 stars 13 forks source link

Validator: check for unknown keys in the map #38

Open tfgordon opened 7 years ago

tfgordon commented 7 years ago

I mistyped the key "argument_scheme" as "argumentation_schemes" and it took me while to find the problem, since the validator did not report an error.

Extend the validator to check that all the top-level keys are defined in Carneades. That is, in the set { "meta", "statements", "issues", "arguments", "issue_schemes", "argument_schemes", "assumptions", "tests" }.

Torjas commented 7 years ago

It seems that this is not possible at the moment, since the validator only sees the Argument graph and not the yaml file. So we either have to rewrite the checker to accept the file or we have to check this in the yaml parser itself?

tfgordon commented 7 years ago

OK. I will reassign this task to Horst, to see if he can do this.