carnegierobotics / multisense_ros

ROS Wrapper for LibMultiSense
Other
7 stars 18 forks source link

Importable xacro fixes to remove duplicate root frames and fix typos #61

Closed mattalvarado closed 1 year ago

mattalvarado commented 1 year ago

Resolve #58 and #59

To avoid confusion this removes the origin->head transform which creates multiple root's of the MultiSense TF tree

swiz23 commented 1 year ago

Why not delete the importable urdfs altogether? The PR in its current state would just be making the importable camera macro essentially equivalent to the camera macro itself.

mattalvarado commented 1 year ago

Why not delete the importable urdfs altogether? The PR in its current state would just be making the importable camera macro essentially equivalent to the camera macro itself.

Thanks for the suggestion. I figured you might have had a use case for them with the issues you were posting. I agree they are redundant, and make sense to be deleted. Updated the PR to do that.

swiz23 commented 1 year ago

this looks good to me.