search

carnisj / bcdi

BCDI: tools for pre(post)-processing Bragg coherent X-ray diffraction imaging data
Other
23 stars 17 forks source link

Standardize terms #146

Closed bfrosik closed 2 years ago

bfrosik commented 2 years ago

When referring to specifics about experiment preprocessing/phasing/postprocessing different terms may be used. It would be beneficial if the names are standardized across all the community. This would remove any misunderstanding.

DSimonne commented 2 years ago

Hi, actually I was thinking about dividing the GUI in a few "main" tabs, current ideas are

I don't know if those were the terms you were looking to define ? What do you use in the APS community ?

bfrosik commented 2 years ago

David, That is what I am thinking of. As far as separate tabs in GUI for different phases we have that implemented in cohere-scripts. https://github.com/AdvancedPhotonSource/cohere-scripts/blob/main/scripts/cdi_window.py

bfrosik commented 2 years ago

I have created a file with proposed terms, I don't know where to put it in repository, so I leave it to Jerome. I will attach my file then

bfrosik commented 2 years ago

bcdi names.docx

bfrosik commented 2 years ago

Closed by mistake

carnisj commented 2 years ago

Try to have a look at the Nexus format, this is going to become the standard. Maybe there is already some ontology defined.

DSimonne commented 2 years ago

There is a NXprocess class but it's quite vague

DSimonne commented 2 years ago

Hi,

So I kept the idea of

You can view a cxi file here.

To take into account the nomenclature for the NXS architecture, I have done the following:

bfrosik commented 1 year ago

In APS we divide pre-processing into beamline_preprocess, which does the instrument correction, and standard_preprocess, which can be applied to any corrected data, regardless which beamline it came from, and it includes the aliens removal, centering, binning, cropping, and padding. Then we have reconstruction, your name phase retrieval is good too. And then we have Beamline_visualization.

The tabs on the GUI are called differently though. They are:

It might be a good idea to change the tabs, and your suggested names are good start. Although the 'beamline' word is important here in the beamline preprocessing, versus standard preprocessing.

Barbara

From: David @.> Sent: Thursday, October 7, 2021 4:46 AM To: carnisj/bcdi @.> Cc: Frosik, Barbara B. @.>; Author @.> Subject: Re: [carnisj/bcdi] Standardize terms (#146)

Hi, actually I was thinking about dividing the GUI in a few "main" tabs, current ideas are

I don't know if those were the terms you were looking to define ? What do you use in the APS community ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/carnisj/bcdi/issues/146#issuecomment-937630937, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD3SCMDNBI4BQAT63K2GJFTUFVUBBANCNFSM5FO6YHMA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.