carnival-data / carnival

JVM property graph data unification framework
https://carnival-data.github.io/carnival/
GNU General Public License v3.0
7 stars 2 forks source link

Gradle Plugin V3 #103

Closed augustearth closed 1 year ago

augustearth commented 1 year ago

The Gradle plugin carnival-grade is mostly obsolete in V3. The only part that might still be useful is the addition of dependencies that is done by CarnivalLibraryPlugin. CarnivalApplicationPlugin can probably be removed entirely. CarnivalLibraryPlugin can be renamed to CarnivalPlugin and just do the dependency stuff.

Related to the plugin are the references to carnival.home in the code. They are mostly gone, but should be removed entirely.

Similarly, references to logback.configurationFile in the top level build.gradle should also be reconsidered. They should probably stay, but should be reviewed.

Tasks

augustearth commented 1 year ago

logback.configurationFile

What's happening in build.gradle makes sense.... We want the log settings to propagate when running Carnival tests.

What's happening in the Carnival application plugin can be done by client application code. We should add something to the demonstration app to show how it could work with Micronaut apps.

augustearth commented 1 year ago

This is done. CarnivalLibraryPlugin and CarnivalApplicationPlugin both still exist, but only CarnivalLibraryPlugin is used to create the plugin which is now just called 'carnival'.