Review JOSS paper text - Githubissues

carnival-data / carnival

JVM property graph data unification framework

https://carnival-data.github.io/carnival/

GNU General Public License v3.0

7 stars 2 forks source link

Review JOSS paper text #105

Closed kinow closed 2 weeks ago

kinow commented 1 year ago

Hi @hjwilli :wave: !

I will add my review of the Carnival JOSS paper text here :+1:

[x] in the summary, on this part "Information about data providence", did you mean "data provenance"?
[x] and in "Data pertaining to the set of study subjects was striped", s/striped/stripped? (or maybe trimmed?)
[x] in "Uses", use cases are described in different scenarios; are these cases documented somewhere; in one it says the "The source data repositories included a relational data warehouse "... is that a GitHub source repository somewhere?
[x] #111

Cheers -Bruno

kinow commented 1 year ago

The third item in the list above, about use cases and the data or sources for these cases, is related to the following pending item in my review for the JOSS paper:

Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.

hjwilli commented 1 year ago

Hi @kinow, regarding the third item, the data warehouse project is about human subject research and involves proprietary data schemas and protected information, and cannot be made public. The demonstration project referenced in the paper is public and is intended to help meet the reproducibility need, it contains synthetic clinical data in relational format.

kinow commented 1 year ago

Hi @kinow, regarding the third item, the data warehouse project is about human subject research and involves proprietary data schemas and protected information, and cannot be made public. The demonstration project referenced in the paper is public and is intended to help meet the reproducibility need, it contains synthetic clinical data in relational format.

@hjwilli maybe the information above should be included in the paper? I looked at the currently rendered version in the JOSS paper pull request, and I can see the mention of the demonstration project, but you start saying "Additionally, the demonstration project...". IMHO, it would be best precede that with a note that the use cases mentioned have proprietary data, and that the demonstration project is public, etc. More or less what you said above.

WDYT?

hjwilli commented 2 weeks ago

Thank you @kinow, I've just updated the paper to include that information as you suggested above.

kinow commented 2 weeks ago

Looks good to me! (one minor comment in a commit, extra "with", can be fixed in the next days).