carnival-data / carnival

JVM property graph data unification framework
https://carnival-data.github.io/carnival/
GNU General Public License v3.0
7 stars 2 forks source link

Make installation instructions more prominent in the documentation for users #107

Closed kinow closed 1 year ago

kinow commented 1 year ago

Hi,

For the JOSS paper review, I looked for the installation instructions of Carnival.

Initially it wasn't clear whether it was published to Maven Central or not, whether I should user Docker, etc.

I think now I've found the docs to install it, under the getting started page.

kinow commented 1 year ago

This issue is related to the final pending items in my review

Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item. Functionality: Have the functional claims of the software been confirmed? Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems). Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?

hjwilli commented 1 year ago

Hi @kinow, I believe these issues have now all been addressed, and the documentation on how to use carnival in a project should be clearer: https://carnival-data.github.io/carnival/#using-carnival

Please let us know if this is sufficient!

kinow commented 1 year ago

Thank you @hjwilli ! I will start the review process again over this weekend. Thank you!

kinow commented 1 year ago

The installation/usage instructions look good to me. I've used Groovy+Grapes in the past, and I believe users and readers would be able to read Grapes' docs (if needed) and follow the steps in the new docs. Thanks @hjwilli ! Closing.