search

carnival-data / carnival

JVM property graph data unification framework
https://carnival-data.github.io/carnival/
GNU General Public License v3.0
7 stars 2 forks source link

Remove secondaryIdFieldMap #23

Closed augustearth closed 4 years ago

augustearth commented 4 years ago

Related to https://github.com/pmbb-ibi/carnival/issues/20.

We can remove secondaryIdFieldMap prior to removing KeyType. Probably best to factor out into a distinct issue.

augustearth commented 4 years ago

secondaryIdFieldMap maps a field name to a KeyType. While we can and should remove KeyType, secondaryIdFieldMap is used to format output values. Data elements that are tagged as ID fields undergo special formatting, including lower casing the identifier. while it is for sure my opinion that identifiers should never rely on casing, I wonder how useful this is for client data files that may not have such a restriction. I feel like the identifier field of a MappedDataTable is Carnival's domain and therefore it is fine to impose this behavior. that's probably the only place, though...

augustearth commented 4 years ago

remove secondaryIdFieldMap from:

augustearth commented 4 years ago

GenericDataTable had some other related machinery: idKeysCompleted. I cannot find any uses of them in the core. I am thinking they were used by Penn code. Will remove this functionality along with the rest. Again, we can add it back in if desired.