carnival-data / carnival

JVM property graph data unification framework
https://carnival-data.github.io/carnival/
GNU General Public License v3.0
7 stars 2 forks source link

Remove ConstrainedPropertyDefTrait #37

Closed augustearth closed 3 years ago

augustearth commented 3 years ago

The mechanics of ConstrainedPropertyDefTrait are causing problems. It turns out that adding ConstrainedPropertyDefTrait to a PropertyDefTrait using the 'as' keyword is super-neat, but also causes problems. See implementing traits at runtime. Keeping the original PropertyDefTrait object, which will be an Enum normally, is desirable.

Having PropertyDefTrait and ConstrainedPropertyDefTrait seemed cleaner, but since it is causing issues and is not really required, will move the functionality of ConstrainedPropertyDefTrait to PropertyDefTrait and call it a day.

augustearth commented 3 years ago

This is done.