CoreGraph to Carnival

[augustearth]

CoreGraph to Carnival

Re-brand the CoreGraph as a Carnival. A Carnival is an object that encapsulates the graph model, validator, and underlying graph database.

• [x] Class renames and removals
• [x] Replace Defaults with configuration object
• [x] Remove CarnivalLocalDirInit

Questions?

• All the graph methods that take a Graph and/or GraphTraversalSource as parameters, do they now accept a Carnival?
• When and how are graph models applied/associated with a Carnival?

Originally posted by @augustearth in https://github.com/carnival-data/carnival/issues/59#issuecomment-1115512291

[augustearth]

Class Renames and Removals

Class Removals

• [x] Remove CoreGraphValidator

Class Rename

• [x] CoreGraph to Carnival
• [x] CoreGraphNeo4j to CarnivalNeo4j
• [x] CoreGraphTinker to CarnivalTinker
• [x] CoreGraphUtils to CarnivalUtils
• [x] CoreGraphSchema to DefaultGraphSchema
• [x] GremlinGraphValidator to DefaultGraphValidator

[augustearth]

Replace Defaults with configuration object

References to remove

• [x] MappedDataTable
• [x] DataTableVineMethod
• [x] JsonVineMethod
• [x] VineMethod

Files to delete

• [x] Defaults.groovy

CarnivalConfiguration

• [x] Create a CarnivalNeo4jConfiguration class that contains everything needed to create a CarnivalNeo4j
• [x] Create a CarnivalNeo4 with a CarnivalNeo4jConfiguration

Vine Configuration

• [x] VineConfiguration object with everything that VineMethod, JsonVineMethod, and DataTableVineMethod need
• [x] Add a constructor VineMethod(VineConfiguration)

[augustearth]

Remove CarnivalLocalDirInit

CarnivalLocalDirInit is there because running Carnival in a CI environment needed it to create the required directories. The directory situation needs to be more explicit. I think that the sub-directories should be created automatically if they are not present. Need to coordinate with @hjwilli to make sure whatever used CarnivalLocalDirInit will be ok after the removal.

Files to delete

• [x] CarnivalLocalDirInit.groovy