Refactor and allow requests for differently cased README files - Githubissues

carolinaknoll / awesome-gamified

:eyeglasses: Awesome Gamified - See your progress and save awesome links you've already seen!

https://carolinaknoll.github.io/awesome-gamified/

MIT License

73 stars 20 forks source link

Refactor and allow requests for differently cased README files #15

Closed katherine95 closed 4 years ago

katherine95 commented 4 years ago

What does this PR do?

This PR fixes the Axios requests made to differently cased README files of different repositories.

Type of change:

[x] Bug fix (non-breaking change which fixed an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update.

How Has This Been Tested?

Clone this repository and install requirements using yarn install command
Git checkout to katherine95:fix-readme-requests
Run yarn start
Navigate to Front-end Development and click on CSS Frameworks

Checklist:

[x] README contents of the selected repo displays.

Screenshots (if appropriate):

Screenshot 2019-10-01 at 17 35 44

carolinaknoll commented 4 years ago

Hi @katherine95!

This looks great! I noticed a few issues with loading a README file for the first time, but they have no relation with your changes, so I will be working on them tomorrow.

Thank you for your contribution, using the Github API for getting READMEs is a fantastic idea! It works with all readme files and doesn't care their extension or naming convention. It is awesome that you brought this to the project! 😄

Thank you! I will merge it and deploy it live. 🚀