search

carolineartz / rubocop-rails-order_model_macros

Extension of RuboCop for ordering macro style methods in Rails models
https://rubygems.org/gems/rubocop-rails-order_model_macros
MIT License
7 stars 5 forks source link

Support Rubocop 0.50.0 #2

Closed anthony-robin closed 6 years ago

anthony-robin commented 7 years ago

Hi ! I tried to install your gem on my Rails project which has Rubocop version to 0.50.0. I couldn't make it to work as your gem doesn't have support for versions upper than 0.47.

May you create a new release supporting 0.50 ? Thanks :)

carolineartz commented 7 years ago

Sure I can try to do that sometime this week or next. Thanks for the heads up.

anthony-robin commented 6 years ago

any news on this ? :)

carolineartz commented 6 years ago

@anthony-robin it looks like the signature of Rubocop::Cop::Cop#add_offense changed to no longer support positional args as of 0.52. Any chance you can ~> 0.52.0?

anthony-robin commented 6 years ago

Do you mean your code won't work with 0.52 or do you plan to change it to be compatible ?

carolineartz commented 6 years ago

I mean it wouldn't work with 0.50.0, but it would work with 0.52 (actually >= 0.51).

anthony-robin commented 6 years ago

Yes, that's perfect :)

carolineartz commented 6 years ago

ok, i just pushed 0.2.0 to rubygems, good to close this issue?

anthony-robin commented 6 years ago

Thanks !