search

carolinux / gdata-python-client

Automatically exported from code.google.com/p/gdata-python-client
0 stars 1 forks source link

[PATCH] Add contact group query support to the contacts.client #435

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Unable to modify the contact groups query

Add a ContactGroupsQuery to the contact client,  the patch is available in my 
clone in rev.

http://code.google.com/r/vinces1979-gdata-python-client/source/detail?r=38476649
cfcb6b2006c5a3b7497fea157398b1ff

Original issue reported on code.google.com by vi...@vinces.ca on 13 Aug 2010 at 3:37

GoogleCodeExporter commented 9 years ago 
Issue 436 has been merged into this issue.

Original comment by joe.gregorio@gmail.com on 10 Sep 2010 at 3:00

GoogleCodeExporter commented 9 years ago 
This is a good start. Some notes:

1. You list start-index and updated-min as parameters, but those aren't legal 
Python parameter names.

2. Please add unit tests. Please see tests/gdata_tests/analytics/query_test.py 
as an example.

Original comment by joe.gregorio@gmail.com on 10 Sep 2010 at 3:19

GoogleCodeExporter commented 9 years ago 
Joe,

1. good catch, sorry will fix that

2. I will add some tests then bump this ticket

Original comment by vi...@vinces.ca on 10 Sep 2010 at 3:27

GoogleCodeExporter commented 9 years ago 
Joe,

I updated the ContactQuery to use GDQuery which makes testing a lot easier
  -- http://code.google.com/r/vinces1979-gdata-python-client/source/detail?r=c87371c0d8bd34c499f3f8e56109adad8f8ac300

Added Tests here:
  -- http://code.google.com/r/vinces1979-gdata-python-client/source/detail?r=2ce566c92078ab9d0abf394bff1f2625dbab04d2

Let me know if you see any issues there.

Vince

Original comment by vi...@vinces.ca on 28 Sep 2010 at 9:27

GoogleCodeExporter commented 9 years ago 
Seems to be fixed :-)

Original comment by ala...@google.com on 7 Oct 2011 at 9:42

GoogleCodeExporter commented 9 years ago 
Did these patches not get applied? Still no GroupsQuery in the client.

Original comment by tyl...@securecominc.com on 19 Jun 2013 at 7:54