search

carolinux / gdata-python-client

Automatically exported from code.google.com/p/gdata-python-client
0 stars 1 forks source link

withKey element of docs ACLs not supported #489

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The withKey element of docs ACLs documented at
http://code.google.com/apis/documents/docs/3.0/developers_guide_protocol.html#AC
LKeys
is not supported by the Python client.

I have a patch for this which I will upload.

Original issue reported on code.google.com by dglasser on 18 Jan 2011 at 6:43

GoogleCodeExporter commented 9 years ago 
http://codereview.appspot.com/4068041

Original comment by dglasser on 18 Jan 2011 at 6:56

GoogleCodeExporter commented 9 years ago 
Thanks for the patch!  Much appreciated.

Original comment by vicfry...@google.com on 18 Jan 2011 at 9:08

GoogleCodeExporter commented 9 years ago 
Oops, that diff was against svn, not hg. Recreated vs hg (patch is the same):

http://codereview.appspot.com/4023042

(I work at Google so CLAs should not be necessary.)

Original comment by dglasser on 18 Jan 2011 at 9:21

GoogleCodeExporter commented 9 years ago 
By the way, I noticed that this was marked as fixed but I don't think you've 
applied the patch yet. Was this intentional?

Original comment by glas...@google.com on 21 Jan 2011 at 10:16

GoogleCodeExporter commented 9 years ago 
Valid, will wait on tests for this patch.

Original comment by vicfry...@google.com on 22 Jan 2011 at 2:21

GoogleCodeExporter commented 9 years ago 
Patch committed at 0437cfb50509.

Original comment by joe.gregorio@gmail.com on 24 Jan 2011 at 5:54

GoogleCodeExporter commented 9 years ago

Original comment by joe.gregorio@gmail.com on 7 Mar 2011 at 4:27