search

carolzbnbr / OnScreenSizeMarkup.Maui

OnScreenSizeMarkup.MAUI is a XAML markup extension that facilitates the control of UI elements (Views) according to the physical screen size category of a device (such as medium-sized, large-sized devices, etc.). This extension provides a flexible way to tailor your interface to various screen dimensions.
35 stars 2 forks source link

Update readme.md #3

Closed Andy-Donegan closed 9 months ago

Andy-Donegan commented 9 months ago

Define Category Mappings, fixed code to work with Latest Maui .Net 8 and added the using statements which are required within App.cs Current code in document for this does not work.

Added additional example in used in styles showing how to use the plugin for more complex items like Margin etc.

Thank you for a very elegant and straight forward solution.

carolzbnbr commented 9 months ago

Hi Andy, thanks for submitting changes, i really appreciate your effort toward the project and also the community.

I've revised the changes you made but I could only find changes on the readme.md file, but on your submission description you mentioned other changes. Maybe you forgot to commit some files... Could you please verify?

Kind regards, Carol

Andy-Donegan commented 9 months ago

Hi Carol, The changes are only for documentation on the readme, sorry my explanation may have been poor. It was just the issue for the change for .Net 8 in the App.cs file and then an additional example of how to setup Margins etc.

I would not dare to touch your code it is working fantastically for us without issue.

carolzbnbr commented 9 months ago

Done accepting you pr and merged.

Thanks Andy.

And by the way, My code is not untouchable, and anyone interested in contributing is welcome to do so.