caronc / apprise-api

A lightweight REST framework that wraps the Apprise Notification Library
https://hub.docker.com/r/caronc/apprise
MIT License
580 stars 50 forks source link

Add a configuration option for attachment limit #130

Closed dnbz closed 10 months ago

dnbz commented 11 months ago

:bulb: The Idea Currently, the file upload limit is 5MB. Telegram, for instance, allows for a 50MB limit, and I'd like to upload larger files there. Perhaps I've missed something, but I haven't seen this as a configurable option anywhere

caronc commented 11 months ago

I can't see this limit you describe that is in place.

There is a 100MB limit in the API here.

Can you share a bit more info how you feel that you're restricted to 50MB? What steps are you doing (it would help me out with more details)?

dnbz commented 10 months ago

I believe this is the file where it's defined and i haven't seen any way to override it https://github.com/caronc/apprise/blob/f82934a8158260410c74399113353dbb22d43f2b/apprise/attachment/AttachBase.py#L71

This is the kind of error i get:

2023-08-25 13:23:36,424 - INFO - Sent Telegram notification.
2023-08-25 13:23:36,425 - ERROR - Content exceeds allowable maximum file length (5120KB): file:///builds/app-debug.apk
2023-08-25 13:23:36,425 - ERROR - Could not access attachment file:///builds/app-debug.apk.

The last log line is also a bit misleading since the file is present and the error for when the file doesn't exist is different

This is the kind of command i ran

apprise -vv -t 'test' -b 'beep boop' "tgram://${TG_BOT_TOKEN}/${TG_CHAT_ID}"  --attach ./app-debug.apk

The problem for me is that Telegram allows me to upload files with maximum size of 50MB while apprise has a 5MB limit

caronc commented 10 months ago

I think I resolved this one for you; going to push to the master for your review.

dnbz commented 10 months ago

Thanks! Installed from master today and larger file uploads work as expected now