caronc / apprise-api

A lightweight REST framework that wraps the Apprise Notification Library
https://hub.docker.com/r/caronc/apprise
MIT License
575 stars 49 forks source link

Refactor General Display of Loaded URLs #174

Closed YouveGotMeowxy closed 3 months ago

YouveGotMeowxy commented 4 months ago

:question: Question

Not a problem or issue or anything, but looking at the WebUI, would it make more sense to place the "Loaded Configuration" section on the "overview" tab, to the bottom of the actual "Configuration" tab instead of where it's currently at?

And maybe even style it into more of a table instead of stacked and full width? Would save a lot of scrolling if a lot of configs/tags are added. :)

Something kinda like this:

-------------------
| config | config |
-------------------
| config | config |
-------------------
| config | config |
-------------------
| config | config |
-------------------

instead of how it is now:

---------
| config | 
---------
| config | 
---------
| config | 
---------
| config | 
---------
| config | 
---------
| config | 
---------
| config | 
---------
| config | 
----------
caronc commented 4 months ago

I'm a terrible front end developer. I abs love your suggestion, but would eagerly invite someone to help pick up the challenge 🙂🙏

YouveGotMeowxy commented 4 months ago

Wish I knew how to do it myself, or I'd be glad to help. :)

STaRDoGG commented 4 months ago

Like this?

image

I can't move the List to the Config tab though; that requires editing the source html.

caronc commented 4 months ago

@STaRDoGG if you're feeling brave, the whole interface could use a reface. It's not very mobile friendly, when you swash the page even a little it starts stacking.

I'll echo how horrible of a Front End Developer I am. What you're seeing is basic jquery (which is very dated), vanillaJS and just straight up HTML and CSS.

The function of the pages achieve what is needed, but they're not that professionally presented i don't think.

If you want to take a stab at cleaning it up or even just the shared image you placed, go for it! It looks great! :heart:

STaRDoGG commented 4 months ago

@caronc I can tweak a few things like I've been doing, but a whole reface I just don't have time for. I'm buried in projects, lol.

I'm really also not the greatest UI guy in the world, and don't really know the UI framework you used at all, and don't have a dev environment for it all setup. I'm just tweaking things via the browser dev inspector.

I really don't think the UI is that bad though for what it needs to do.

If you want to move that little bit of html over from the Overview tab ("Loaded Configuration")

https://github.com/caronc/apprise-api/blob/3fabdad84d48aa9cdf24177a05f6c717a429f5a4/apprise_api/api/templates/config.html#L120

to the Configuration tab, like mentioned above, I can add a PR for the styling in the screenshot.

YouveGotMeowxy commented 4 months ago

Any updates on this? :)

STaRDoGG commented 4 months ago

Any updates on this? :)

shrug I'm waiting on @caronc

caronc commented 4 months ago

Go for it, i welcome any PR 🙂

YouveGotMeowxy commented 4 months ago

Go for it, i welcome any PR 🙂

@caronc I think he's waiting on this first? :)

If you want to move that little bit of html over from the Overview tab ("Loaded Configuration") to the Configuration tab, like mentioned above, I can add a PR for the styling in the screenshot.

caronc commented 3 months ago

I think i'm happy with the results; i'll merge the code after your review (see attached PR for screenshots).

caronc commented 3 months ago

Massive refactoring complete of css, extra tab as requested, and cleaned up some of the general look of both dark and light theme.

Closing off issue; right now content is available from :edge branch, but soon :latest