caronc / apprise-api

A lightweight REST framework that wraps the Apprise Notification Library

https://hub.docker.com/r/caronc/apprise

MIT License

638 stars 56 forks source link

Don't run the web process as root #28

Closed RealOrangeOne closed 4 years ago

RealOrangeOne commented 4 years ago

Description:

It's bad practice to run things as root. nginx handles changing its own users, but gunicorn doesn't, and so is always run as root.

This changes it to run as www-data, the same user nginx runs its child processes as.

It's worth noting this change will likely break existing installs, as apprise will no longer be able to write to the previously written configuration files.

Checklist

[ ] The code change is tested and works locally.
[x] There is no commented out code in this PR.
[ ] No lint errors (use flake8)
[ ] tests added

(I've not done much in-depth testing on this change yet)

codecov-commenter commented 4 years ago

Codecov Report

Merging #28 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          372       372           
=========================================
  Hits           372       372

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 907743f...d5b1b88. Read the comment docs.

caronc commented 4 years ago

Thank you very much for this Pull Request! :+1: