caronc / apprise

Apprise - Push Notifications that work with just about every platform!
https://hub.docker.com/r/caronc/apprise
BSD 2-Clause "Simplified" License
11.71k stars 410 forks source link

Improve split and truncate overflow methods #1035

Closed caronc closed 9 months ago

caronc commented 9 months ago

Description:

Related issue (if applicable): #845

Improve ?overflow=split and ?overflow=truncate functionality to factor in the length of the title in it's calculations.

Checklist

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@845-bodylen-overflow-improvement

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  <apprise url related to ticket>
codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c240f8b) 99.27% compared to head (cf6c683) 99.27%. Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1035 +/- ## ======================================= Coverage 99.27% 99.27% ======================================= Files 135 135 Lines 17557 17574 +17 Branches 3583 3588 +5 ======================================= + Hits 17429 17446 +17 Misses 119 119 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.