Refactored (Split and Truncate) Overflow Engine

caronc / apprise

Apprise - Push Notifications that work with just about every platform!

BSD 2-Clause "Simplified" License

11.71k stars 410 forks source link

Description:

Related issue (if applicable): #845

A massive refactoring of the Overflow Engine handling the truncate and split functionality. A more dynamic and clean presentation can be adapted per upstream service.

Checklist

[x] The code change is tested and works locally.
[x] There is no commented out code in this PR.
[x] No lint errors (use flake8)
[x] 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@845-overflow-continued-improvements

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  <apprise url related to ticket>?overflow=split

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f3c699a) 99.27% compared to head (11ba9e9) 99.27%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1038 +/- ## ======================================= Coverage 99.27% 99.27% ======================================= Files 135 135 Lines 17574 17600 +26 Branches 3588 3592 +4 ======================================= + Hits 17446 17472 +26 Misses 119 119 Partials 9 9 ```

caronc / apprise