Closed caronc closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.27%. Comparing base (
52aa7f4
) to head (519dec9
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description:
Related issue (if applicable): #1020
This is in efforts to address a racing condition that happens in Home Assistant Core/110242
Effectively what this patch does is adds a mutex around the (notification) plugin loading. In addition to this, a flag is tracked when loading has been completed allowing threaded or asynchronous instances of Apprise to work correctly.
Previously (before this patch), the Apprise library would start loading it's (notification) plugins dynamically after first being instantiated. However second instances would not recognize that the first instance hadn't completed loading all the libraries. The second instance would however detect that plugins were loaded (it really depends on how far the first instance got during it's startup) and assumed it was okay to start processing URLs it was fed. If your notification URL referenced a plugin that simply hadn't loaded yet (it's a timing thing), it would flat out fail.
Checklist
flake8
)Testing
Anyone can help test this source code as follows: