caronc / apprise

Apprise - Push Notifications that work with just about every platform!
https://hub.docker.com/r/caronc/apprise
BSD 2-Clause "Simplified" License
10.9k stars 384 forks source link

ntfy loaded topic count bugfix #1094

Closed caronc closed 2 months ago

caronc commented 2 months ago

Description:

Related issue (if applicable): n/a

All services should return 1 at the very least; never 0 when getting a count.

Checklist

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@ntfy-len-bugfix

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  ntfy://host/topic
codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.27%. Comparing base (26d8e45) to head (34725d4). Report is 15 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1094 +/- ## ========================================== - Coverage 99.27% 99.27% -0.01% ========================================== Files 136 138 +2 Lines 17753 17954 +201 Branches 3623 3663 +40 ========================================== + Hits 17625 17824 +199 - Misses 119 121 +2 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.