caronc / apprise

Apprise - Push Notifications that work with just about every platform!
https://hub.docker.com/r/caronc/apprise
BSD 2-Clause "Simplified" License
10.9k stars 384 forks source link

freemobile:// msg moved from GET parameters and into payload #1106

Closed caronc closed 2 months ago

caronc commented 2 months ago

Description:

Related issue (if applicable): #1090

Bugfix to move msg into payload (and out of kwarg GET parameters)

Checklist

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1090-mobile-free-bugfix

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  freemobile://user@password
caronc commented 2 months ago

@rabonarca would you mind giving this branch a try to see if it helps your situation?

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.27%. Comparing base (cced5ed) to head (36393b1).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1106 +/- ## ========================================== - Coverage 99.27% 99.27% -0.01% ========================================== Files 139 139 Lines 18029 18028 -1 Branches 3680 3680 ========================================== - Hits 17899 17898 -1 Misses 121 121 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rabonarca commented 2 months ago

@rabonarca would you mind giving this branch a try to see if it helps your situation?

With the changes I proposed it still didn't work. As I had more time today for testing I managed to make it work by adding 'Content-Type': 'application/json' to the headers and keeping the msg in the payload.

caronc commented 2 months ago

Fixed in #1109