caronc / apprise

Apprise - Push Notifications that work with just about every platform!
https://hub.docker.com/r/caronc/apprise
BSD 2-Clause "Simplified" License
10.9k stars 384 forks source link

[Bug]: SMTP notifications to IP are broken #1113

Closed kroese closed 2 months ago

kroese commented 2 months ago

In versions 1.7.5 and below, you could always send email notifications to an URL which contains the IP address of the SMTP server, like this:

apprise mailto://10.0.0.195:25/?to=alerts@example.com&from=sender@example.com

In version 1.7.6 this is broken and returns the error:

smtplib.SMTPServerDisconnected: please run connect() first

For further details see this issue:

https://github.com/dgtlmoon/changedetection.io/issues/2324

dgtlmoon commented 2 months ago

In versions 2.7.5 and below, you could always send email notifications to an URL which contains the IP address of the SMTP server, like this:

@kroese I think you mean 0.7.5?

kroese commented 2 months ago

@dgtlmoon No, I ment 1.7.5 :) Corrected now..

caronc commented 2 months ago

Well that's embarrassing 😬; even with all of my unit tests, this still got missed. Thank you very much for reporting this. I'll get this fixed for sure (hopefully this weekend).

caronc commented 2 months ago

Issue will be resolved in the next release; i need to address a few more bugs before i merge this though; closing off issue. :rocket:

dgtlmoon commented 2 months ago

fantastic :) thanks again!