caronc / apprise

Apprise - Push Notifications that work with just about every platform!
https://hub.docker.com/r/caronc/apprise
BSD 2-Clause "Simplified" License
10.9k stars 384 forks source link

Custom Plugin Attachment Support Enforced + Added Testing #1115

Closed caronc closed 2 months ago

caronc commented 2 months ago

Description:

Related issue (if applicable): #1110

Upon further investigating, the CustomPlugin always has a utf-8 character string; this is confirmed with the added test cases.

One thing to note that before this PR, the Custom Plugin module did not support Attachments (as it should have been allowed). This has been fixed in this PR.

Checklist

Testing

n/a - more unit tests added in this PR

codecov-commenter commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.28%. Comparing base (22c979d) to head (242207f). Report is 1 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1115 +/- ## ======================================= Coverage 99.27% 99.28% ======================================= Files 139 139 Lines 18053 18056 +3 Branches 3688 3689 +1 ======================================= + Hits 17923 17926 +3 Misses 121 121 Partials 9 9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.