caronc / apprise

Apprise - Push Notifications that work with just about every platform!
https://hub.docker.com/r/caronc/apprise
BSD 2-Clause "Simplified" License
10.9k stars 384 forks source link

Update apprise_api token length #1120

Closed isometimescode closed 2 months ago

isometimescode commented 2 months ago

Description:

Related issue (if applicable): caronc/apprise-api#187

It looks like the apprise-api README suggests a key length of up to 128 chars, so updating the apprise_api plugin token check seemed appropriate.

Checklist

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/isometimescode/apprise.git@apprise-api-token-length

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  apprise://example.com/asdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdfasdf
isometimescode commented 2 months ago

Also, I'm not sure if it's worth updating the wiki page at https://github.com/caronc/apprise/wiki/Notify_apprise_api, but that would be up to you since I can't submit a PR for that.

caronc commented 2 months ago

This is great! I'll definitely update the wiki. Thank you for the PR 🙏🚀