caronc / apprise

Apprise - Push Notifications that work with just about every platform!
https://hub.docker.com/r/caronc/apprise
BSD 2-Clause "Simplified" License
10.9k stars 384 forks source link

Slack files upload deprecation #1130

Closed delenamalan closed 1 month ago

delenamalan commented 1 month ago

Description:

Related issue (if applicable): #1126

The Slack files.upload method is deprecated. Instead, you now need to use the files.getUploadURLExternal and files.completeUploadExternal methods to upload files to Slack.

Checklist

Local test result:

Screenshot 2024-05-24 at 11 39 24

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/delenamalan/apprise.git@slack-files-upload-deprecation

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  --attach /path/to/image.png \
  "slack://xoxb-your-slack-key/#your-channel"
caronc commented 1 month ago

Amazing work! Thank you for this PR!