caronc / apprise

Apprise - Push Notifications that work with just about every platform!
https://hub.docker.com/r/caronc/apprise
BSD 2-Clause "Simplified" License
11.71k stars 410 forks source link

Refactored the way Notifiarr Discord users are mentioned #1153

Closed caronc closed 2 months ago

caronc commented 3 months ago

Description:

Related issue (if applicable): n/a

The concern came from the Notifiarr Discord chat where one would invoke discord mentions from Apprise.

Checklist

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@notifiarr-discord-mentions-refactor

# Test out the changes with the following command:
apprise -t "Test Title" -b "Hi <@123>!" \
  notifiarr://webhook/discord_channel_no/
codecov-commenter commented 3 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.26%. Comparing base (6733953) to head (f28615d).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1153 +/- ## ========================================== - Coverage 99.28% 99.26% -0.03% ========================================== Files 142 142 Lines 18440 18428 -12 Branches 3763 3761 -2 ========================================== - Hits 18309 18292 -17 - Misses 121 124 +3 - Partials 10 12 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.