search

caronc / apprise

Apprise - Push Notifications that work with just about every platform!
https://hub.docker.com/r/caronc/apprise
BSD 2-Clause "Simplified" License
12.11k stars 422 forks source link

Add support for `desktop-notifier` #742

Open amotl opened 2 years ago

amotl commented 2 years ago

:loudspeaker: What is the name of the service?

Add an adapter for desktop-notifier by @samschott.

:link: Provide some details about the service that can help with it's development.

:bulb: Anything else?

@portalzine made a corresponding contribution at https://github.com/jpmens/mqttwarn/pull/581, replacing the macOS-specific service plugin of mqttwarn. I love it.

As a followup of adding support for desktop-notifier, maybe get rid of Apprise's native implementations for Desktop notifications on Linux, macOS, and Windows ^1, as they are intrinsically harder to maintain than an adapter for a single library which already might do the job well enough.

samschott commented 2 years ago

Always great to see interest in desktop-notifier. Note however that the Windows implementation is still experimental and I don't currently have access to a Windows machine or VM for development. The macOS and Linux implementations can be relied upon.