caronc / apprise

Apprise - Push Notifications that work with just about every platform!
https://hub.docker.com/r/caronc/apprise
BSD 2-Clause "Simplified" License
11.81k stars 413 forks source link

License Attribution Question #969

Closed yajrendrag closed 1 year ago

yajrendrag commented 1 year ago

:question: Question

I have written an apprise notification based plugin for a project i support. Upon task completion, the plugin sends a notification alerting the user of the status of a task. The project is written in python, so i simply did an import of apprise and configured it as needed. Users can customize their systems with whatever underlying notification system they wish to use via the config API.

my question is do i need to include your license somewhere and if so where would you recommend? the project i'm using it in uses the GNU General Public License.

Thanks, Jay

caronc commented 1 year ago

It's your plugin, you can license it specifically as GNU. No worries there.

If your plugin is to be merged (via PR) with Apprise and sit in the /apprise/plugin/ directory, then I'd prefer it adapted to the same license as everything else.

It's great to hear you were successful using the custom plugin. 🙂

yajrendrag commented 1 year ago

it's not an apprise plugin - i'm writing a plugin for another tool - unmanic (it's a video automation stack). the unmanic plugin is using apprise via a pip install... i'm just trying to figure out what, if anything, i need to do to be compliant with your license. When i pip install it, the Apprise license gets downloaded. beyond that, i'm not sure what i need to do..

If i put a note in the copyright section of my unmanic plugin code saying something like the plugin uses the Apprise project which is copyright Chris Caron subject to the license file (give path to the local license file or to the license file here on yoru site...) is that sufficient?

caronc commented 1 year ago

Sounds fine to me

yajrendrag commented 1 year ago

one other question wrt the 3rd clause of the license. In the LICENSE file the 3rd clause reads:

    3. Neither the name of Django nor the names of its contributors may be used
       to endorse or promote products derived from this software without
       specific prior written permission.

but in the all of the code blocks it reads:

# 3. Neither the name of the copyright holder nor the names of its
#    contributors may be used to endorse or promote products derived from
#    this software without specific prior written permission.

is Django supposed to be in there? & moreover is it just saying i cant imply that the copyright holder nor any of the Apprise project's contributors has endorsed or promoted my work where i incorporate Apprise?

caronc commented 1 year ago

Oops, good catch. This license was copied from them as it was difficult for me to find the correct wording and have GitHub recognize it. I didn't realize i missed that. Great catch! Thank you. I'll open a pr and fix it for the next release

caronc commented 1 year ago

License issue fixed in be73b03a9841e6919c6cfdf15d87d5671b0919d7 (thanks again for pointing that out)

yajrendrag commented 1 year ago

I'm still a bit confused by the 3rd term - i don't really understand what i am allowed to do and not do...

3. Neither the name of Apprise nor the names of its contributors may be used
       to endorse or promote products derived from this software without
       specific prior written permission

i read this to mean, that, for example in my project i cannot name the plugin something like "apprise_notifier". OK. i can name it something else.

But in the description of my other project's plugin i have to be able to say that the notifier uses apprise and here are the instructions with a link to the apprise docs so they can understand which underlying notification systems are supported and how to structure the url etc. Is that allowable under this term of the license?

thanks.

caronc commented 1 year ago

I'm just going to drop that line. You can use Apprise and advertise that you support it. This is not an issue at all. Your findings are amazing, this is what i get for copying and pasting.

Apprise is meant to be absolutely free for public use. I just don't want someone taking the source and selling it to someone as is (in its raw state). This was the only reason i switched from MIT to GPLv3.

Please feel free to name your program what you wish. I'll do another pr soon

yajrendrag commented 1 year ago

ah, thanks so much for your flexibility - it's very much appreciated. & sorry for any inconvenience, i tend to operate on the ask permission vs seeking forgiveness - it's less stress...

caronc commented 1 year ago

I updated the License properly now (BSD v2 now)

sorry for any inconvenience,

Don't be sorry at all. Your feedback had me even second guessing what i had in place!

Good luck with your application and thank you for choosing to use Apprise! :rocket: :slightly_smiling_face: