Submitting Week-2-Project-New-York-Times-Article-Search

[carot264]

Here is my finished week 2 assignment ! Thank you. /cc @codepathreview @codepath

[chug2k]

@coderschoolreview not codepathreview :joy:

[hoanle]

@carot264

:+1: nice work. Much better than the 1st assignment. A few notes after checking out the code:

• Properly reused the single base method in search activity to fetch results for both initial load and the pagination
• Nice to see you added the search box to the ActionBar!
• Properly used spinners (with populated values) or checkboxes to allow users to select filters. But increase the size of spinner. It's hard to click :dancer:
• Properly sent and received relevant filters using a callback to pass data between activities
• Good to see you used a filters object to represent the filters to apply to the query
• Nice job adding the share intent to the article detail view! Unfortunately, i tried to share by FB but no url was shared
• Try out the third-party ButterKnife library to simplify a lot of boilerplate findViewById() calls.
• When user open the app, app should display some data instead of a blank page like now

Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[carot264]

Thanks for your review !