search

carousell / pickle

Carousell flavoured image picker with multiple photo selections.
https://carousell.github.com/pickle
Apache License 2.0
60 stars 25 forks source link

No permission dialog on iOS11 when permission is denied #16

Open daveluong opened 7 years ago

daveluong commented 7 years ago

Steps to reproduce

Go to Device Settings Select Pickle Example Select Photos, Select "Never" Then, launch Pickle Example Select any Here, you will see the old image picker format, even though you do not give Picker Example access to Photos.app Then, select a photo You will see a blank page that is unresponsive, requiring you to kill app

Actual outcome unresponsive page

Expected outcome If access to Photos is disabled, client should show a page that informs you that access is required before proceeding to Sell Form. See attached image for what the prompt is on production for iOS10 and below

Upon initial investigation, it appears to be bug in UIImagePicker in iOS11.

bcylin commented 7 years ago

Is there any plan to work around this issue or to replace the permission denied screen?

daveluong commented 7 years ago

No concrete plan at the moment. I think we will continue observing, if it escalates we might need to handle the denied state using custom view instead pf relying on UIImagePickerController

daveluong commented 6 years ago

@bcylin What is the reason that we're showing UIImagePickerController when the permission is case .denied, .restricted: ?

daveluong commented 6 years ago

Proposed fix:

Solution 1: Add 1 more function to ImagePickerDelegate that call delegate when permission status is .denied or .restricted and let delegate handle it on their own

Solution 2: Create a custom view to show permission error within Pickle instead of relying on UIImagePickerViewController

bcylin commented 6 years ago

It was because of the product design. It shows the system message when the permission is not granted.