search

carousell / pickle

Carousell flavoured image picker with multiple photo selections.
https://carousell.github.com/pickle
Apache License 2.0
60 stars 25 forks source link

Xcode 10 #26

Closed bcylin closed 6 years ago

bcylin commented 6 years ago

Update the project to Xcode 10

carouselljenkins commented 6 years ago

@rance-attack, can you review this pull request?

carouselljenkins commented 6 years ago
:white_check_mark: Yay.
:white_check_mark: Please update CHANGELOG.md.
1 Warning
:warning: Big PR
:white_check_mark: Pickle/Classes/ImagePickerController.swift#L229 - Pickle/Classes/ImagePickerController.swift#L229 has linter issue: Initializing an optional variable with nil is redundant..
:white_check_mark: Pickle/Classes/ImagePickerController.swift#L299 - Pickle/Classes/ImagePickerController.swift#L299 has linter issue: Fallthroughs can only be used if the case contains at least one other statement..

Generated by :no_entry_sign: Danger

tflhyl commented 6 years ago

lol @bcylin dont realize u also fixing..

bcylin commented 6 years ago

Oh I forgot there’s Hacktoberfest. I seem to be a day early. 😅