Support video in the picker

carousell / pickle

Carousell flavoured image picker with multiple photo selections.

https://carousell.github.com/pickle

Apache License 2.0

60 stars 25 forks source link

Support video in the picker #44

Closed amelia2801 closed 5 years ago

amelia2801 commented 5 years ago

Provide options to display images only, videos only, or both images and videos in the ImagePickerController

carouselljenkins commented 5 years ago

@hungnguyenvn, can you review this pull request?

carouselljenkins commented 5 years ago

	1 Error
:no_entry_sign:	Please update CHANGELOG.md.

Generated by :no_entry_sign: Danger

amelia2801 commented 5 years ago

@daveluong @bcylin i made some changes based on your comments. Please help review again 🙏 Do I need to update CHANGELOG? And when should we update version?

bcylin commented 5 years ago

It should be all right to add a ## Next release section in CHANGELOG.md.

Since the master branch is protected, I usually have another PR to run make bump version=<number> and update README if needed.

daveluong commented 5 years ago

Thank you @bcylin for helping us to review the PRs! Truly appreciate it :)

amelia2801 commented 5 years ago

Thank you @bcylin and @daveluong ! 😄