search

carousell / pickle

Carousell flavoured image picker with multiple photo selections.
https://carousell.github.com/pickle
Apache License 2.0
60 stars 25 forks source link

Update project to support Swift 5 and Xcode 12 #57

Open gugell opened 3 years ago

gugell commented 3 years ago

Updated project to the latest version of Xcode. Fixed some of the swiftlint warnings

bcylin commented 3 years ago

@gugell thanks for the pull request 👍

You may also need to update the config to use xcode12 on Travis CI.

https://github.com/carousell/pickle/blob/57fa753b4f39fe926f33bcc35895d7790f3a4c76/.travis.yml#L2

gugell commented 3 years ago

Can you also put a label hacktoberfest-accepted to participate in hackoctoberfest ?

cstlex commented 3 years ago

Isn't limited should be handled with authorized not denied?