Closed philtomson closed 5 years ago
Hello,
What do you mean by fields?
BTW I would only commit a specific feature, without the bunch of other comments and small asides features you put in.
It appears to be some small bad design concerns that lower the code quality, for example self.best_ppl = 100000000000000000.0
which should be replaced by np.inf
, unnecessary nested if block in the train_shared
method and badly formatted comments. Of course I may be wrong and those choices justified, this is just my first feeling.
Apologies. This pull-request wasn't intended to go to this repo, but to my fork of this repo, so please disregard.
(As for 'fields' - I was trying to load in a pre-trained DAG but found that it would balk at certain fields in the DAG which is why I had to set strict= False there)
Alright, I'll close this PR then.
This has changes to allow reading of child/controller model .pth files that have more fields than the original class had.