carpedm20 / emoji

emoji terminal output for Python
Other
1.87k stars 273 forks source link

add Japanese and Korean #252

Closed VSteinborn closed 1 year ago

VSteinborn commented 1 year ago

Proposal to add Korean and Japanese support.

Adds the Dakuten and Handakuten as well as the Interpunct to the emoji name pattern.

cvzi commented 1 year ago

Could the interpunct be replaced with a underscore?

Edit: I see it's not the Western interpunct but a katakana version. Then it's ok for me, I would have preferred not to include the Western interpunct, since it could be used as a good delimiter alternative to the standard colons.

cvzi commented 1 year ago

Purely from a coding POV it looks good to me, I don't know anything about Japanese or Korean though

TahirJalilov commented 1 year ago

Thank you!