carpedm20 / emoji

emoji terminal output for Python
Other
1.87k stars 273 forks source link

Add purely_emoji() #266

Closed marmistrz closed 1 year ago

marmistrz commented 1 year ago

As discussed in #262.

cvzi commented 1 year ago

It also needs to be added here: https://github.com/carpedm20/emoji/blob/fde2fa78b74fdc4a85999fa2ba47c3858c79cb5d/emoji/__init__.py#L21-L23

Can you add it to the table in the documentation as well:

https://github.com/carpedm20/emoji/blob/fde2fa78b74fdc4a85999fa2ba47c3858c79cb5d/docs/index.rst?plain=1#L404-L408

and

https://github.com/carpedm20/emoji/blob/fde2fa78b74fdc4a85999fa2ba47c3858c79cb5d/docs/api.rst?plain=1#L28-L32

And could you change the docstring of is_emoji https://github.com/carpedm20/emoji/blob/fde2fa78b74fdc4a85999fa2ba47c3858c79cb5d/emoji/core.py#L315-L319

to Returns True if the string is a single emoji, ...

marmistrz commented 1 year ago

Updated

marmistrz commented 1 year ago

What are we currently waiting for? Could we have a new release after this has been merged?

TahirJalilov commented 1 year ago

@marmistrz Thank you for your PR!