Migrate to pyproject.toml

carpedm20 / emoji

emoji terminal output for Python

Other

1.87k stars 273 forks source link

Migrate to pyproject.toml #289

Closed lovetox closed 4 months ago

lovetox commented 4 months ago

Closes #288

lovetox commented 4 months ago

I ran the tests, it does not work on python 3.6, because setuptools on that python version does not support editable installs for projects with only pyproject.toml

I see the following options

Drop python 3.6 compatibility
Disable the editable install test
Wait with the move to pyproject.toml

cvzi commented 4 months ago

I think, remove the editable install. I see no reason why the editable install would need to be tested, not sure why I added that in the first place.

lovetox commented 4 months ago

I found more problems, the short story is, setuptools 59 was just not far enough in the implementation for pyproject.toml. I added a commit to drop python 3.6 compatibility.

I looked at the stats and run them for march 2024

python 3.6 | 0.35% │ 10,700

TahirJalilov commented 4 months ago

Thank you for your PR!