carpentries-i18n / carpentry-theme

Other
0 stars 1 forks source link

index and setup page not linked properly #12

Open dpshelio opened 6 years ago

dpshelio commented 6 years ago

At least when online on gh-pages the index and setup pages for English are getting a 404 because jekyll is not building them as: /index/ or /setup/. This could be solved by adding permlinks to these.

dpshelio commented 4 years ago

Probably we need to change https://github.com/carpentries-i18n/carp-theme/blob/e7710037f29f126b5810425ccdd747f81a4a0806/_includes/navbar.html#L37 to point only to include.pathLocale and on the index.md pages for source and translated languages to have the following options:

Similarly for other pages:

TomKellyGenetics commented 3 years ago

(though we need to check how we want to refer to this page: coc,conduct,code_of_conduct,... The "official" theme uses: CODE_OF_CONDUCT.html. However, the problem then is that the translations will become: es/CODE_OF_CONDUCT/index.html and that's harder to wire)

Switching between languages doesn't work if the files are names differently. If they're all called CODE_OF_CONDUCT and have a permalink: */conduct/ field it seems to work.