Open dpshelio opened 6 years ago
Probably we need to change https://github.com/carpentries-i18n/carp-theme/blob/e7710037f29f126b5810425ccdd747f81a4a0806/_includes/navbar.html#L37 to point only to include.pathLocale
and on the index.md
pages for source and translated languages to have the following options:
Source:
root: .
permalink: index.html
translation:
root: es
permalink: es/index.html
as index is the only page that doesn't follow the pattern /:path/index.html
Similarly for other pages:
CoC:
source
root: .
permlink: /conduct/
translation
root: es
permlink: es/conduct/
(though we need to check how we want to refer to this page: coc
,conduct
,code_of_conduct
,...
The "official" theme uses: CODE_OF_CONDUCT.html
. However, the problem then is that the translations will become: es/CODE_OF_CONDUCT/index.html
and that's harder to wire)
Setup:
source
root: .
permlink: /setup/
translation
root: es
permlink: es/setup/
License:
permalink: /LICENSE/
root: .
root: es
permalink: /LICENSE/
episodes/AIO:
permalink: /aio/
permalink: /aio/index.html
permalink: es/aio/
permalink: es/aio/index.html
extras/reference:
root: .
permlink: /reference/
and as above for the translations...
extras/about:
permlink: /about/
extras/design, extras/discuss, extras/exercises, extras/guide are like the above.
extras/figures => has the link to figures/index and that one works without any change!
(though we need to check how we want to refer to this page: coc,conduct,code_of_conduct,... The "official" theme uses: CODE_OF_CONDUCT.html. However, the problem then is that the translations will become: es/CODE_OF_CONDUCT/index.html and that's harder to wire)
Switching between languages doesn't work if the files are names differently. If they're all called CODE_OF_CONDUCT
and have a permalink: */conduct/
field it seems to work.
At least when online on gh-pages the index and setup pages for English are getting a 404 because jekyll is not building them as:
/index/
or/setup/
. This could be solved by addingpermlinks
to these.