carpentries-incubator / SDC-BIDS-dMRI

Introduction to dMRI
https://carpentries-incubator.github.io/SDC-BIDS-dMRI/
Other
23 stars 17 forks source link

MAINT: Clarification and spelling updates #212

Closed kaitj closed 1 year ago

kaitj commented 2 years ago

Updates the notebooks for some of simple / small fixes suggested in the reviews during the coding sprint. Mostly capitalization and rewording a sentence or two for clarification and to bring more inline across lessons.

review-notebook-app[bot] commented 2 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

netlify[bot] commented 2 years ago

Deploy Preview for carpentries-dmri ready!

Name Link
Latest commit 0135989bfa78e572db363239fe63ae64be976621
Latest deploy log https://app.netlify.com/sites/carpentries-dmri/deploys/629b80611a0ad40009397290
Deploy Preview https://deploy-preview-212--carpentries-dmri.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jhlegarreta commented 1 year ago

Test errors stem from the fact that we are using DIPY 1.3.0, and NumPY 1.24, and the latter removed all support for np.float. https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3773484312/jobs/6414959616#step:13:102

https://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations

gtab not existing is a consequence of the above: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3773484312/jobs/6414959616#step:13:134

DIPY 1.4.1 contains the necessary fixes. Upgrading DIPY in a separate PR, then will rebase this PR.

jhlegarreta commented 1 year ago

Cross-referencing PR #218.

jhlegarreta commented 1 year ago

Python 3.9 exceeded the maximum execution time of 6 hours; Python 3.7 and 3.8 succeeded: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3778995767

Merging.