Closed kaitj closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Name | Link |
---|---|
Latest commit | 0135989bfa78e572db363239fe63ae64be976621 |
Latest deploy log | https://app.netlify.com/sites/carpentries-dmri/deploys/629b80611a0ad40009397290 |
Deploy Preview | https://deploy-preview-212--carpentries-dmri.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Test errors stem from the fact that we are using DIPY 1.3.0, and NumPY 1.24, and the latter removed all support for np.float
.
https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3773484312/jobs/6414959616#step:13:102
https://numpy.org/doc/stable/release/1.24.0-notes.html#expired-deprecations
gtab
not existing is a consequence of the above:
https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3773484312/jobs/6414959616#step:13:134
DIPY 1.4.1 contains the necessary fixes. Upgrading DIPY in a separate PR, then will rebase this PR.
Cross-referencing PR #218.
Python 3.9 exceeded the maximum execution time of 6 hours; Python 3.7 and 3.8 succeeded: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3778995767
Merging.
Updates the notebooks for some of simple / small fixes suggested in the reviews during the coding sprint. Mostly capitalization and rewording a sentence or two for clarification and to bring more inline across lessons.