carpentries-incubator / SDC-BIDS-dMRI

Introduction to dMRI
https://carpentries-incubator.github.io/SDC-BIDS-dMRI/
Other
22 stars 16 forks source link

ENH: Pin `matplotlib` package version #214

Closed jhlegarreta closed 1 year ago

jhlegarreta commented 1 year ago

Pin matplotlib package version.

Fixes:

ImportError: cannot import name 'get_renderer' from 'matplotlib.tight_layout'
(/opt/hostedtoolcache/Python/3.9.15/x64/lib/python3.9/site-packages/matplotlib/tight_layout.py)

raised at: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3298335648/jobs/5440315644#step:13:132

netlify[bot] commented 1 year ago

Deploy Preview for carpentries-dmri ready!

Name Link
Latest commit b3720d16dc5c48291f56f936d4577925c1d1332d
Latest deploy log https://app.netlify.com/sites/carpentries-dmri/deploys/6352e791e1aaaf00081d0b9a
Deploy Preview https://deploy-preview-214--carpentries-dmri.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jhlegarreta commented 1 year ago

Looks like a bit is missing in the GHA config file to check out the proper commit, or an issue in the GHA end. v3 is also out (but similar problems have been reported).

In any case, merging as the previous builds with matplotlib 3.5.3 were working.

jhlegarreta commented 1 year ago

The website is being built successfully: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3303231017

The tests are passing: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3303231018