search

carpentries-incubator / SDC-BIDS-dMRI

Introduction to dMRI
https://carpentries-incubator.github.io/SDC-BIDS-dMRI/
Other
22 stars 16 forks source link

DOC: Update introduction and preprocessing lessons #222

Closed Bradley-Karat closed 8 months ago

Bradley-Karat commented 1 year ago

Added in and expanded upon the current information in the introduction and preprocessing lessons. This includes changes to improve clarity and the logical flow of the lesson. Also changed the first figure of the introduction lesson to something that is a bit more clear (i.e. easier to understand the signal change via gradient direction change).

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jhlegarreta commented 1 year ago

@Bradley-Karat would you have time to address the comments or do you prefer to hand it over to somebody else? Thanks.

jhlegarreta commented 1 year ago

@Bradley-Karat would you have time to address the comments or do you prefer to hand it over to somebody else? Thanks.

Bradley-Karat commented 1 year ago

@Bradley-Karat would you have time to address the comments or do you prefer to hand it over to somebody else? Thanks.

Sorry Jon just saw this now. I can go through and address some of these comments.

jhlegarreta commented 11 months ago

Also, change the commit subject and message: the preprocessing episode was also changed.

jhlegarreta commented 10 months ago

@Bradley-Karat can you please address the comments made?

netlify[bot] commented 10 months ago

Deploy Preview for carpentries-dmri failed.

Name Link
Latest commit db4baa2d7f17e2127351de0671b0b3412f406d24
Latest deploy log https://app.netlify.com/sites/carpentries-dmri/deploys/64ff653e416be60008ad9cac
jhlegarreta commented 8 months ago

@Bradley-Karat Can the comments above be addressed, please?

jhlegarreta commented 8 months ago

Pinging @Bradley-Karat.

netlify[bot] commented 8 months ago

Deploy Preview for sdc-bids-dmri failed.

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/sdc-bids-dmri/deploys/6551230b9eb8613213a65c7d
Bradley-Karat commented 8 months ago

@Bradley-Karat Can the comments above be addressed, please?

Sorry Jon just got to this, just made those changes.

jhlegarreta commented 8 months ago

Thanks for addressing the comments @Bradley-Karat.

Usual tests timing out. Merging.