ENH: Miscellaneous improvements to build, test GHA workflow - Githubissues

carpentries-incubator / SDC-BIDS-dMRI

Introduction to dMRI

https://carpentries-incubator.github.io/SDC-BIDS-dMRI/

Other

22 stars 16 forks source link

ENH: Miscellaneous improvements to build, test GHA workflow #235

Closed jhlegarreta closed 11 months ago

jhlegarreta commented 11 months ago

ENH: Reuse environment variables for FSL and ANTS
ENH: Clean cache memory of downloaded package files in GHA workflow
ENH: Do not try to cache protected system folders

jhlegarreta commented 11 months ago

The Ubuntu dependencies caching has been failing since at least the following commit: https://github.com/jhlegarreta/SDC-BIDS-dMRI/tree/ab2ba297ba8496448176cfe2b98a97ffb74175f5 where the GHA workflows reported the warnings: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3303914423

The immediately successful build corresponding to commit https://github.com/jhlegarreta/SDC-BIDS-dMRI/tree/b3720d16dc5c48291f56f936d4577925c1d1332d did not report warnings related to the Ubuntu dependencies caching step: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/3299689775

No changes had been made between the two concerning the Ubuntu dependencies caching step.

The solution was proposed in https://github.com/actions/cache/issues/324#issuecomment-773406088, but then it looks like restoring the cache may require superuser permissions that cannot be set.

Maybe the caching step will require superuser permissions: https://github.com/mxschmitt/action-tmate/blob/dfb94ec78701b33c98463d487c94fb5241e96942/action.yml#L8

or https://github.com/scroll-tech/zkevm-circuits/pull/245/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR57

Other relevant information: https://github.com/actions/cache/issues/133

jhlegarreta commented 11 months ago

Warnings are still present: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/5680950298/job/15396061990?pr=235#step:26:6

Maybe the PR needs to be merged so that changes are reflected in the build.

Merging.

jhlegarreta commented 11 months ago

Warnings are still present after merging: https://github.com/carpentries-incubato/SDC-BIDS-dMRI/actions/runs/5685982448/job/15411962264#step:26:6

Now the path added to the exception rules: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/5685982448/job/15411962264#step:2:4

are different in our case: https://github.com/carpentries-incubator/SDC-BIDS-dMRI/actions/runs/5685982448/job/15411962264#step:26:4

PR coming to fix this.

jhlegarreta commented 11 months ago

PR coming to fix this.

PR #236.