search

carpentries-incubator / SDC-BIDS-fMRI

fMRI Imaging Analysis
https://carpentries-incubator.github.io/SDC-BIDS-fMRI/
Other
41 stars 39 forks source link

importing plotting from nilearn is not consistent across the lesson #17

Closed dpshelio closed 3 years ago

dpshelio commented 3 years ago

For example, sometimes (ep 6) it's imported as:

from nilearn import plotting

where others (ep 3, ep 4, ep 7) do:

from nilearn import plotting as plot

In one case (ep 5), it's aliased as plt but then matplotlib.pyplot uses plt too.

jerdra commented 3 years ago

Hi @dpshelio!

Thanks for pointing this out! I think you make a good point about avoiding any confusion with pyplot. Having a consistent import convention across all nilearn modules in general is probably a good idea:

nilearn.image --> nimg nilearn.plotting --> nplot nilearn.signal --> nsig

Lmk if you'd like to contribute this as a PR