Closed zkamvar closed 1 year ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/carpentries-incubator/bioc-project/compare/md-outputs..md-outputs-PR-73
The following changes were observed in the rendered markdown documents:
03-installing-bioconductor.md | 54 +-
config.yaml (gone) | 85 ---
md5sum.txt | 34 +-
renv.lock (gone) | 1152 -----------------------------------------
4 files changed, 19 insertions(+), 1306 deletions(-)
:stopwatch: Updated at 2023-09-05 14:51:49 +0000
All checks look green. Not sure what else to check before merging.
I should probably compile it at least once locally and briefly inspect the resulting site. I can't think of anything else.
All checks look green. Not sure what else to check before merging.
I should probably compile it at least once locally and briefly inspect the resulting site. I can't think of anything else.
You shouldn't need to build on your local machine if you don't have the time. The pull request workflow is described in the Reviewing a Pull Request chapter in the Workbench documentation.
The key things to look at are the files that have changed, which is present in the diff between the md-outputs branch and the md-outputs-PR73 branch and shown in summary in the first comment (note: the renv.lock and config.yaml files disappearing is an ephemeral and cosmetic bug that I cannot pin down, but I assure you it is not a problem).
03-installing-bioconductor.md | 54 +-
config.yaml (gone) | 85 ---
md5sum.txt | 34 +-
renv.lock (gone) | 1152 -----------------------------------------
4 files changed, 19 insertions(+), 1306 deletions(-)
One thing that I see is that the BiocManager::valid()
now returns an output of [1] TRUE
instead of a warning and sessionInfo()
Thanks.
One thing that I see is that the BiocManager::valid() now returns an output of [1] TRUE instead of a warning and sessionInfo()
Having a look at https://carpentries-incubator.github.io/bioc-project/03-installing-bioconductor.html I think your PR is good in that the automated code returns TRUE
while the following note demonstrates an output that isn't TRUE.
In brief, it's a good thing that the evaluated code returns TRUE again.
Hopefully, we won't go more than a month without these updates.
As a maintainer, if you ever need to update the packages for this lesson, you can go to https://github.com/carpentries-incubator/bioc-project/actions/workflows/update-cache.yaml and trigger an update using the "Run Workflow" button on the right hand side.
If that does not work you should be able to use the commands above to update it manually on your local computer (and please raise an issue on https://github.com/carpentries/workbench/issues so the workbench maintainers can see if there is a solution to that problem)
This workflow runs on the first Tuesday of the month at 00:00 UTC (in reality, it runs every Tuesday, but only builds on the first Tuesday) and generates a pull request like https://github.com/carpentries-incubator/bioc-project/pull/72. It failed the last two months due to an update in {renv} that caused the bootstrapping mechanism to be invalidated.
I've run the package update manually because the automated workflow was having trouble after the release of {renv} 1.0.0.
This brings in updates to 26 packages. Please wait for the output to run and then check for any new errors, warnings or surprising output changes.
I ran the following commands to update the cache with {renv} 1.0.2