Closed zkamvar closed 1 year ago
Thank you for your pull request :smiley:
:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
:mag: Inspect the changes: https://github.com/carpentries-incubator/bioc-rnaseq/compare/md-outputs..md-outputs-PR-79
The following changes were observed in the rendered markdown documents:
03-import-annotate.md | 17 +-
04-exploratory-qc.md | 34 +-
07-gene-set-analysis.md | 8 +-
config.yaml (gone) | 86 -
...tial-expression-rendered-unnamed-chunk-19-1.png | Bin 22609 -> 22606 bytes
...a-design-rendered-unnamed-chunk-13-2.png (gone) | Bin 19957 -> 0 bytes
...a-design-rendered-unnamed-chunk-18-2.png (gone) | Bin 19957 -> 0 bytes
...a-design-rendered-unnamed-chunk-23-2.png (gone) | Bin 19957 -> 0 bytes
...a-design-rendered-unnamed-chunk-26-2.png (gone) | Bin 19957 -> 0 bytes
...ne-set-analysis-rendered-unnamed-chunk-15-1.png | Bin 191067 -> 191001 bytes
md5sum.txt | 36 +-
renv.lock (gone) | 2762 --------------------
12 files changed, 48 insertions(+), 2895 deletions(-)
:stopwatch: Updated at 2023-09-05 16:15:36 +0000
Thanks @zkamvar! Just wanted to be sure - should the config.yaml
and renv.lock
files disappear (the figures may be ok, perhaps I should actually render them in another way)? I see the same happened in the other bioc lessons.
Just wanted to be sure - should the
config.yaml
andrenv.lock
files disappear (the figures may be ok, perhaps I should actually render them in another way)? I see the same happened in the other bioc lessons.
This is a weird thing that happens only in the pull request previews and I'm not sure why, but these actions are ultimately harmless as they always end up appearing in the correct places in the end.
Ok, thanks!
I think for the images, it's a bit confusing as to why they would disappear like that and I'm running the lesson locally now to see if that's a real problem or if that's an artefact of the PR process. One thing I would recommend is to use a package like {namer} to name the chunks: https://jumpingrivers.github.io/namer/ and then continue to name them as you go along.
It looks like they appear locally, so it's likely a bug in the PR preview mechanism.
👍🏻 And yes, totally agree about the naming, this was an oversight from my side - I'll update the chunks.
I've run the package update manually because the automated workflow was having trouble after the release of {renv} 1.0.0.
This brings in updates to 50 packages. Please wait for the output to run and then check for any new errors, warnings or surprising output changes.
I ran the following commands to update the cache with {renv} 1.0.2